[Analytics Hub] Add network actions #8211
Conversation
ealeksandrov
added
feature: stats
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Clear and works as described! 👍
Results are stored in existing
@publishedvars without any UI binding yet.
Just want to note that if it's more straightforward to bind the response directly to the card view models, feel free to remove those @published vars. They made more sense to me when I thought we'd be fetching from storage!
|
Thanks for the review!
Yeah, maybe we can remove them, but let's make it a scope of a different UI-focused PR. |
Ecarrion
left a comment
Ecarrion
left a comment
There was a problem hiding this comment.
Not a review, feel free to merge with the above approval 😅
| do { | ||
| try await retrieveOrderStats() | ||
| } catch { | ||
| DDLogWarn("⚠️ Error fetching analytics data: \(error)") |
There was a problem hiding this comment.
Do we have a task to handle these errors later?
| func retrieveOrderStats() async throws { | ||
| // TODO: get dates from the selected period | ||
| let currentMonthDate = Date() | ||
| let previousMonthDate = Calendar.current.date(byAdding: .month, value: -1, to: Date())! |
There was a problem hiding this comment.
This is temporary right? The ! concerned me 😅
You can test the changes from this Pull Request by:
|
ealeksandrov
deleted the
issue/8189-add-analytics-hub-network-actions
branch
Part of #8189
Description
This PR adds 2 network requests in
AnalyticsHubViewModelthat fetch stats data for current and previous period.Input dates are hardcoded for current/previous month now, should later use input from time range selector.
Results are stored in existing @published vars without any UI binding yet.
Testing
Add a breakpoint/
print(...)in the end ofAnalyticsHubViewModels initializer, checkcurrentOrderStatsandpreviousOrderStatsvalues.RELEASE-NOTES.txtif necessary.